[PATCH] os/log: adjust gcc version conditions for #pragma

Keith Packard keithp at keithp.com
Thu Sep 11 18:19:26 PDT 2014


Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

> In commit e67f2d7e0f9189beb2907fa06cff5ecc7f35f922 ("gcc 4.2.1 doesn't
> support #pragma GCC diagnostic ignored"), some compile time
> conditionals were added around the #pragma usage. Those conditionals
> ensure that the #pragma are not used on gcc <= 4.2.
>
> However, the usage of #pragma diagnostic inside functions was only
> added in gcc 4.6, and a build failure is therefore experienced with
> gcc 4.5:

I've gone ahead and merged this; it doesn't appear to break my build,
and could only increase warnings for compiler versions which actually do
support it.
   da4bad6..7a0c79c  master -> master

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140911/b436b571/attachment.sig>


More information about the xorg-devel mailing list