[PATCH 6/8] modesetting: Connect the driver to the build.

Keith Packard keithp at keithp.com
Thu Sep 11 18:06:27 PDT 2014


Eric Anholt <eric at anholt.net> writes:

> +	if test "x$DRM" = xyes; then
> +		dnl 2.4.38 is required for drmPrimeFDToHandle().
> +		PKG_CHECK_EXISTS(libdrm >= 2.4.38)
> +		XORG_DRIVER_MODESETTING=yes
> +	fi
> +

The existing code checks for 2.4.46. Have you verified that the driver
actually works with 2.4.38?


> @@ -144,7 +144,7 @@ static XF86ModuleVersionInfo VersRec = {
>      MODINFOSTRING1,
>      MODINFOSTRING2,
>      XORG_VERSION_CURRENT,
> -    PACKAGE_VERSION_MAJOR, PACKAGE_VERSION_MINOR, PACKAGE_VERSION_PATCHLEVEL,
> +    1, 0, 0,

These numbers seem fictional to me; is there some reason to *not* use
the same version as the X server itself here?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140911/9f2fab0b/attachment.sig>


More information about the xorg-devel mailing list