[patch] xkbcomp: fixing an age-old warning

[Benno Schulenberg]

On Thu, Sep 11, 2014, at 13:01, Ran Benita wrote:
> Actually I'm not so sure. The current behavior of a key-group override
> is per-symbol, e.g.
> 
>     override key <FOO> {
>         [ NoSymbol, B, C ];
>     };
> 
> Means: replace whatever is in the 2nd and 3rd levels with the symbols B
> and C (create them if they do not exist). "override" is almost always
> the default. Often, the key type for both `from` and `into` is not
> specified, so an automatic type is assigned (FindAutomaticType) at a
> later point.
> 
> Now, if we have this:
> 
>     key <FOO> {
>         [1, 2, 3, 4];
>     }
>     [...]
>     override key <FOO> {
>         [ NoSymbol, B, C ];
>     };
> 
> With current code you get: [1, B, C, 4], with your patch: [1, B, C].
> I think the current behavior is a bit more intuitive,

Hmm.  I wouldn't call that more intuitive, I would call it plain wrong.  :)
If I wanted an overridden key to retain a possible fourth symbol, I would
write "[ any, B, C, any ]" instead of "[ any, B, C ]".

> and we should not
> change it.  [...]

Fair enough... let's assume that some definitions depend on the current
behaviour.

> So if you want to get rid of the warning, I'd suggest either:
> 
> 1. Change the test to
> 
>         if ((from->numLevels[group] > into->numLevels[group])
>             || (override && from->types[group] != None))

Implemented in the revised patch, attached.

> 2. Just make the warning require a verbosity>0. It is not necessarily
>    a problem if the truncation kicks in, so it should not be displayed
>    to the user by default. However a keymap author would probably like
>    to see it.

I would like to propose that solution for this warning:
Warning:          Symbol map for key <RALT> redefined
                  Using last definition for conflicting fields

Thanks for the detailed review.

Benno

-- 
http://www.fastmail.fm - Or how I learned to stop worrying and
                          love email again

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-When-overriding-a-key-adjust-also-its-number-of-leve.patch
Type: text/x-diff
Size: 1775 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140911/e675c15a/attachment.patch>