[PATCH] xv: Add missing gcstruct.h include

Thierry Reding thierry.reding at gmail.com
Fri Oct 31 05:16:39 PDT 2014


On Thu, Oct 30, 2014 at 02:38:53PM -0700, Keith Packard wrote:
> Thierry Reding <thierry.reding at gmail.com> writes:
> 
> > From: Thierry Reding <treding at nvidia.com>
> >
> > Commit ea3f3b0786d5 (xv: Move xf86 XV color key helper to core.) added
> > code that uses internals of struct _GC. This structure is defined in the
> > include/gcstruct.h header which wasn't included by the source file, only
> > gc.h was. That caused the following build failure:
> >
> > 	  CC       xvmain.lo
> > 	Xext/xvmain.c: In function 'XvFillColorKey':
> > 	Xext/xvmain.c:1114:13: error: dereferencing pointer to incomplete type
> > 	         (*gc->ops->PolyFillRect) (pDraw, gc, nbox, rects);
> 
> I'm curious as to how I'm not seeing this bug?

It seems to be triggered by --disable-xinerama, in which case gcstruct.h
is pulled in via panoramiX.h.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20141031/cd798441/attachment.sig>


More information about the xorg-devel mailing list