[PATCH 2/4] dri2: Automatically fill in the driver name if the DDX doesn't provide it.

Eric Anholt eric at anholt.net
Sat Oct 11 22:58:07 PDT 2014


Mark Marshall <markmarshall14 at gmail.com> writes:

> Just a minor thing
>
> On 10 October 2014 11:09, Eric Anholt <eric at anholt.net> wrote:
>> This will be used by the modesetting driver to support DRI2 across all
>> hardware that can support glamor, and could potentially be used by
>> other drivers that have to support DRI2 on sets of hardware with
>> multiple Mesa drivers.
>>
>> This logic is the same as what's present in the Mesa driver loader,
>> except for the lack of nouveau_vieux support (which requires a
>> predicate on the device).
>>
>> Signed-off-by: Eric Anholt <eric at anholt.net>
>> ---

>>  Bool
>>  DRI2ScreenInit(ScreenPtr pScreen, DRI2InfoPtr info)
>>  {
>> @@ -1525,6 +1578,14 @@ DRI2ScreenInit(ScreenPtr pScreen, DRI2InfoPtr info)
>>          if (!ds->driverNames)
>>              goto err_out;
>>          ds->driverNames[0] = info->driverName;
>
> I assume that you'd want to drop the line above, as it done again in
> the added lines below?

Fixed, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20141012/8dca77d3/attachment.sig>


More information about the xorg-devel mailing list