[PATCH 17/37] misc: Fold together some redundant conditionals

Adam Jackson ajax at redhat.com
Thu Oct 9 06:25:43 PDT 2014


On Thu, 2014-10-09 at 14:47 +0200, Alan Coopersmith wrote:
> On 10/ 8/14 05:04 PM, Adam Jackson wrote:
> > @@ -2576,10 +2576,9 @@ MapWindow(WindowPtr pWin, ClientPtr client)
> >               if (anyMarked) {
> >                   (*pScreen->ValidateTree) (pLayerWin->parent, pLayerWin, VTMap);
> >                   (*pScreen->HandleExposures) (pLayerWin->parent);
> > -            }
> > -            if (anyMarked && pScreen->PostValidateTree)
> > -                (*pScreen->PostValidateTree) (pLayerWin->parent, pLayerWin,
> > -                                              VTMap);
> > +                if (pScreen->PostValidateTree)
> > +                    (*pScreen->PostValidateTree) (pLayerWin->parent, pLayerWin,
> > +                                                  VTMap);
> >           }
> >           WindowsRestructured();
> >       }
> 
> Am I missing something or did you lose the closing } for the if (anyMarked) body
> in this hunk?

I did.  Not at all sure how.  Fixed in the corresponding pull request.

- ajax



More information about the xorg-devel mailing list