[PATCH 3/3] XWayland: Use FocusIn events for keyboard enter

[Daniel Stone]

Hi,

> On 25 Nov 2014, at 12:34 am, Keith Packard <keithp at keithp.com> wrote:
> Daniel Stone <daniels at collabora.com> writes:
>> wl_keyboard::enter is the equivalent of FocusIn + KeymapNotify: it
>> notifies us that the surface/window has now received the focus, and
>> provides us a set of keys which are currently down.
> 
> Why don't you just filter out non-modifier keys and skip those? That
> should provide the basic functionality you want (persistent caps-lock,
> or even shift) without requiring a pile of other changes?

Because that's still a bunch of work, and even then doesn't necessarily get us correct results. It also fixes apps which do trust that the KeymapNotify isn't a pack of lies, which isn't an unreasonable demand to make.

This patch isn't the end of the road; in the end, it should be entirely possible to achieve perfect nesting wrt KeymapNotify events with XWayland, Xephyr, XQuartz, and any combination thereof. This is a relatively start in that direction.

Plus, it helps X catch up to Wayland's start of the art, which you should be all for, no? ;)

Cheers,
Daniel