[PATCH] os: "Server terminated successfully" is not an error

[Eric Anholt]

Keith Packard <keithp at keithp.com> writes:

> Aaron Plattner <aplattner at nvidia.com> writes:
>
>> ErrorFSigSafe calls LogVMessageVerbSigSafe with the message type set to X_ERROR.
>> That generates this in the log:
>>
>>   (EE) Server terminated successfully (0). Closing log file.
>>
>> People periodically report this as an error, sometimes quoting this "error"
>> rather than an earlier error that actually caused a problem.
>>
>> Signed-off-by: Aaron Plattner <aplattner at nvidia.com>
>> ---
>> Is X_NOTICE too weird to use?  X_INFO would work too.
>
> There are only two instances of X_NOTICE in the server today, both seem
> to indicate an unusual situation which the server has recovered
> from. I'd suggest that this should probably be X_INFO instead, which is
> what all of the regular startup messages use.
>
> Otherwise, this looks like a fix that might keep people from
> mis-interpreting this message.
>
> With X_NOTICE -> X_INFO: Reviewed-by: Keith Packard <keithp at keithp.com>

With X_INFO,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20141124/9937914a/attachment.sig>