[PATCH 6/6] present: Set abort_flip on the pending_flip when destroying the Window

Chris Wilson chris at chris-wilson.co.uk
Wed May 28 00:14:04 PDT 2014


Currently, the code asserts that the abort_flip is set on the
pending_flip when the Window is closed. Presumably, it is expected that
a configure event happens before it actually closes causing the pending
present flip to be aborted. In practice, I see the assert.

Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
---
 present/present_screen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/present/present_screen.c b/present/present_screen.c
index 0a525a8..a04317f 100644
--- a/present/present_screen.c
+++ b/present/present_screen.c
@@ -94,7 +94,7 @@ present_clear_window_flip(WindowPtr window)
     present_vblank_ptr          flip_pending = screen_priv->flip_pending;
 
     if (flip_pending && flip_pending->window == window) {
-        assert (flip_pending->abort_flip);
+        flip_pending->abort_flip = TRUE;
         flip_pending->window = NULL;
     }
     if (screen_priv->flip_window == window)
-- 
2.0.0.rc2



More information about the xorg-devel mailing list