[PATCH:xman 1/2] Fix tautology to the intended check.

Alan Coopersmith alan.coopersmith at oracle.com
Thu May 22 22:44:52 PDT 2014


On 05/21/14 03:17 PM, Thomas Klausner wrote:
> From: Jörg Sonnenberger <joerg at NetBSD.org>
>
> Signed-off-by: Thomas Klausner <wiz at NetBSD.org>
> ---
>   handler.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/handler.c b/handler.c
> index e61687e..87a928e 100644
> --- a/handler.c
> +++ b/handler.c
> @@ -320,7 +320,7 @@ SaveFormattedPage(Widget w, XEvent * event, String * params,
>    * If we are not active then take no action.
>    */
>
> -    if (man_globals->tempfile == NULL)
> +    if (man_globals->tempfile[0] == '\0')
>           return;
>
>       switch (params[0][0]) {
>

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list