[PATCH 1/4] fb: fix screen pixmap leak on server reset

Keith Packard keithp at keithp.com
Thu May 22 16:54:10 PDT 2014


Frank Binns <frank.binns at imgtec.com> writes:

> From: Brendan King <brendan.king at imgtec.com>
>
> Call FreePixmap() instead of free() to destroy the screen pixmap in
> fbCloseScreen().
>
> Signed-off-by: Frank Binns <frank.binns at imgtec.com>
> ---
>  fb/fbscreen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fb/fbscreen.c b/fb/fbscreen.c
> index b2b9739..1f91089 100644
> --- a/fb/fbscreen.c
> +++ b/fb/fbscreen.c
> @@ -37,7 +37,7 @@ fbCloseScreen(ScreenPtr pScreen)
>          free(depths[d].vids);
>      free(depths);
>      free(pScreen->visuals);
> -    free(pScreen->devPrivate);
> +    FreePixmap((PixmapPtr)pScreen->devPrivate);
>      return TRUE;
>  }

This fixes the devPrivates counts and nothing else, so we'll reduce the
warnings on recycle.

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140522/2e035b53/attachment.sig>


More information about the xorg-devel mailing list