[PATCH 5/5] ephyr: Fix a bad debug print format string.

Keith Packard keithp at keithp.com
Mon May 12 16:24:30 PDT 2014


Eric Anholt <eric at anholt.net> writes:

> Signed-off-by: Eric Anholt <eric at anholt.net>
> ---
>  hw/kdrive/ephyr/ephyr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/kdrive/ephyr/ephyr.c b/hw/kdrive/ephyr/ephyr.c
> index def50d8..11b5ae9 100644
> --- a/hw/kdrive/ephyr/ephyr.c
> +++ b/hw/kdrive/ephyr/ephyr.c
> @@ -954,7 +954,7 @@ ephyrProcessMouseMotion(xcb_generic_event_t *xev)
>  
>      if (ephyrCursorScreen != screen->pScreen) {
>          EPHYR_LOG("warping mouse cursor. "
> -                  "cur_screen%d, motion_screen:%d\n",
> +                  "cur_screen:%p, motion_screen:%d\n",
>                    ephyrCursorScreen, screen->pScreen->myNum);
>          ephyrWarpCursor(inputInfo.pointer, screen->pScreen,
>                          motion->event_x, motion->event_y);

I'd suggest that this was actually supposed to be
ephyrCursorScreen->myNum instead of just the bare ephyrCursorScreen so
that you'd see the source and target screen by number. That would
require null-checking ephyrCursorScreen as well.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140512/37d59f83/attachment.sig>


More information about the xorg-devel mailing list