[PATCH 1/3] xfree86: Report DRI3 as a built-in module

Chris Wilson chris at chris-wilson.co.uk
Mon May 12 03:06:06 PDT 2014


On Mon, May 12, 2014 at 11:29:58AM +0200, Mark Kettenis wrote:
> > From: Chris Wilson <chris at chris-wilson.co.uk>
> > Date: Mon, 12 May 2014 08:12:37 +0100
> > 
> > This is so that drivers can do a runtime check that DRI3 is available,
> > similar to existing runtime checks performed by the drivers for DRI and
> > DRI2.
> 
> Does that run-time check actually work?  It seems any check based on
> compiled_in_modules would detect DRI3 even on platforms that don't
> support DRI3 or if the server was built using --disable-dri3.

I was just following suit, but you are right...

diff --git a/hw/xfree86/loader/loadmod.c b/hw/xfree86/loader/loadmod.c
index 9f54929..f92ad8d 100644
--- a/hw/xfree86/loader/loadmod.c
+++ b/hw/xfree86/loader/loadmod.c
@@ -838,7 +838,9 @@ static const char *compiled_in_modules[] = {
     "extmod",
     "dri",
     "dri2",
+#if DRI3
     "dri3",
+#endif
     NULL
 };

Should do the right thing, I think.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the xorg-devel mailing list