[PATCH] Fix XNextRequest() after direct usage of XCB
Owen Taylor
otaylor at redhat.com
Fri May 9 15:24:28 PDT 2014
Uli Schlachter wrote:
> > unsigned long XNextRequest(Display *dpy)
> > {
> > + unsigned long next_request;
> > + LockDisplay(dpy);
> > + next_request = _XNextRequest(dpy);
> > + UnlockDisplay(dpy);
> > +
> > return (NextRequest(dpy));
>
> Unused variable "next_request". Did you really mean to write the function
> like this instead of also changing the return statement?
Oops - it does actually work, because the _XNextRequest() updates display->request
as a side effect, so I wasn't dreaming that my testing worked, but still
embarrassing ;-) Sent a newversion.
- Owen
More information about the xorg-devel
mailing list