[PATCH 12/13] mi: Fill all spans for PolyFillArc at once

Keith Packard keithp at keithp.com
Thu May 8 10:30:43 PDT 2014


Eric Anholt <eric at anholt.net> writes:

> Can you give me some justification of what prevents integer overflow
> here?

Here's a replacement which limits the number of spans allocated to
4M. It's still a net -12 lines of code, so I don't feel *too* bad about
making it more complicated. No performance impact as we never get close
to this limit. I do have a test case which now works though, where it
would fail before.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mi-Fill-spans-for-multiple-arcs-in-miPolyFillArc.patch
Type: text/x-diff
Size: 8196 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140508/341b1a5c/attachment.patch>
-------------- next part --------------

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140508/341b1a5c/attachment.sig>


More information about the xorg-devel mailing list