[PATCH keyboard] Init LEDs to zero before querying the value

[Samuel Thibault]

Peter Hutterer, le Thu 08 May 2014 13:01:03 +1000, a écrit :
> This way if the ioctl fails we don't set any unintended LEDs, but really this
> patch is more to silence valgrind:
> 
> ==7129== Conditional jump or move depends on uninitialised value(s)
> ==7129==    at 0x8DF99A1: GetKbdLeds (lnx_kbd.c:79)
> ==7129==    by 0x8DF8853: InitKBD (kbd.c:291)

Err, I would rather say that this is a sign that GetKbdLeds should check
the value returned by ioctl it case it fails, and handle that case,
instead of clearing LEDs?

Or at least a warning should be put, so the user can know something is
weird and precisely where, instead of letting him wondering why the LEDs
are cleared.

> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  src/lnx_kbd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lnx_kbd.c b/src/lnx_kbd.c
> index e69e1b6..811a7d7 100644
> --- a/src/lnx_kbd.c
> +++ b/src/lnx_kbd.c
> @@ -70,7 +70,7 @@ SetKbdLeds(InputInfoPtr pInfo, int leds)
>  static int
>  GetKbdLeds(InputInfoPtr pInfo)
>  {
> -    char real_leds;
> +    char real_leds = 0;
>      int leds = 0;
>  
>      ioctl(pInfo->fd, KDGETLED, &real_leds);
> -- 
> 1.9.0
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
> 

-- 
Samuel
After watching my newly-retired dad spend two weeks learning how to make a new
folder, it became obvious that "intuitive" mostly means "what the writer or
speaker of intuitive likes".
(Bruce Ediger, bediger at teal.csn.org, in comp.os.linux.misc, on X the
intuitiveness of a Mac interface.)