[PATCH v2] fb: fix fast-path detection

Keith Packard keithp at keithp.com
Thu Mar 27 22:22:29 PDT 2014


Daniel Kurtz <djkurtz at google.com> writes:

> Hi Keith,
> Thank you very much for your detailed review.  Your patch looks great.
> Just one small detail.
> Are src/dst_byte_stride still "FbStride" if they count bytes not
> FbBits?   Perhaps they are size_t?

FbStride will be fine (it's an 'int'). X pixmaps cannot be larger than
65536 x 65536 pixels, and so the maximum stride is well under 32 bits,
measured in FbBits, bytes or even bits.

> Either way, for your attached patch:
>
> Reviewed-by: Daniel Kurtz <djkurtz at chromium.org>

Thanks for your review; glad we got that sorted out, and really glad you
identified the bug so clearly.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140327/46300ab8/attachment.sig>


More information about the xorg-devel mailing list