[PATCH util/macros] XORG_PROG_RAWCPP: Add TRADITIONALCPPFLAGS

Hans de Goede hdegoede at redhat.com
Thu Mar 27 05:48:35 PDT 2014


Hi,

On 03/27/2014 01:34 PM, Gaetan Nadon wrote:
> On 14-03-27 07:56 AM, Hans de Goede wrote:
>> In some cases we may want to have -traditional for proper whitespace preserving
>> without -undef, as we actually want the system definitions to be in place
>> so we can #ifdef on them. IE in xinit various .cpp files contain things like
>>  #ifdef __APPLE__ and #ifdef __linux__
>>
>> So this patch adds a TRADITIONALCPPFLAGS variable which contains just
>> -traditional where applicable without the other RAWCPPFLAGS for unsetting
>> the system definitions.
> This preserves backwards compatibility.
> 
> Once pushed, I need to make a new release for util-macros @ version 1.19.
> Any module using TRADITIONALCPPFLAGS will need to require version 1.19.
> 
> 
> Reviewed-by: Gaetan Nadon <memsize at videotron.ca>

Thanks, pushed with your Reviewed-by added.

Once the 1.19 release is done I'll write a patch for xinit to bump the
required util-macros version (and out that in my patchset before the
patch using the new TRADITIONALCPPFLAGS.

Regards,

Hans



More information about the xorg-devel mailing list