[PATCH:libxtrans 2/2] Cast ctype(3) function arguments to unsigned char.

Mark Kettenis mark.kettenis at xs4all.nl
Wed Mar 26 05:08:11 PDT 2014


> From: Thomas Klausner <wiz at NetBSD.org>
> Date: Wed, 26 Mar 2014 12:49:32 +0100
> 
> Fixes warnings on at least NetBSD.
> 
> Signed-off-by: Thomas Klausner <wiz at NetBSD.org>

Reviewed-by: Mark Kettenis <kettenis at openbsd.org>

> ---
>  Xtrans.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Xtrans.c b/Xtrans.c
> index 9a6dfbc..ada53d3 100644
> --- a/Xtrans.c
> +++ b/Xtrans.c
> @@ -164,8 +164,8 @@ TRANS(SelectTransport) (const char *protocol)
>      protobuf[PROTOBUFSIZE-1] = '\0';
>  
>      for (i = 0; i < PROTOBUFSIZE && protobuf[i] != '\0'; i++)
> -	if (isupper (protobuf[i]))
> -	    protobuf[i] = tolower (protobuf[i]);
> +	if (isupper ((unsigned char)protobuf[i]))
> +	    protobuf[i] = tolower ((unsigned char)protobuf[i]);
>  
>      /* Look at all of the configured protocols */
>  


More information about the xorg-devel mailing list