[PATCH 13/20] glamor: Add glamor_program based copy acceleration

Markus Wick markus at selfnet.de
Tue Mar 25 01:45:59 PDT 2014


Am 2014-03-19 06:09, schrieb Keith Packard:
> +        glamor_pixmap_loop(src_priv, src_box_x, src_box_y) {
> +            glamor_pixmap_loop(dst_priv, dst_box_x, dst_box_y) {
> +                for (b = 0; b < nbox; b++) {

Are you sure that this loop order is safe?
Eg what happens, when we copy the first box by box_size/2?
I think we will overwrite the second part of the first box at first and 
then try to copy the overwritten content into the second box.

To fix this issue, we have to loop over the boxes in opposition to the 
copy order. :/

What will happen if we have two boxes defined and the copy of the first 
box will overlapp the second box? Shall we copy the new or the old 
content of the second box? If it's defined to be the new content, we 
also have to move the box loop to the top.



More information about the xorg-devel mailing list