[PATCH 15/20] glamor: Provide a placeholder for glamor_pushpixels

Jasper St. Pierre jstpierre at mecheye.net
Thu Mar 20 21:19:55 PDT 2014


On Thu, Mar 20, 2014 at 7:23 PM, Eric Anholt <eric at anholt.net> wrote:

> Keith Packard <keithp at keithp.com> writes:
>
> > This just calls miPushPixels until glamor uses FBOs for bitmaps
>
> The only cases that PushPixels() is called that I can find:
>
> - miglblt.c
>
> We're doing hand-accelerated glyph blits, so that's gone.
>
> - miarc.c
>
> I tried a few likely x11perfs and nothing hit it.  Eventually I came up
> with
> on -wpcircle100 -rop GXnand, and this patch was 1.5% faster while
> removing apparent rendering bugs.
>

I'd imagine that's hit by anything using XDrawArc. Surprisingly, there's
not many applications using it out there.

Most of what I found by Googling and using code search was example code. In
fact, the only uses I could find of it were in Guy Keren's "Basic Graphics
Programming With The Xlib Library" and O'Reilly's "XLIB Programming Manual".

Things like xclock / oclock seem to use XFillArc twice to stroke an arc or
circle rather than use XDrawArc.


> - midispur.c
>
> I don't think this is a thing we're worried about.
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>



-- 
  Jasper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140321/01150f9e/attachment.html>


More information about the xorg-devel mailing list