[PATCH 00/20] New glamor core rendering code (v2)

Keith Packard keithp at keithp.com
Thu Mar 20 15:25:24 PDT 2014


Markus Wick <markus at selfnet.de> writes:

> This patch series is a very nice cleanup. I like the new way how this 
> functions should be implemented, but the shader generator. Plain GLSL + 
> predefined header are less confusing and more flexible imo.
>
> We also have to figure out on which gl extension we want to rely on. eg 
> I don't think we should fall back to fb because glsl130 + 
> ARB_instanced_arrays aren't available.

I suggest that we not worry about requirements until we find hardware
that we want to use this on that doesn't provide the necessary
features. Pro-actively writing piles of code that never gets used seems
like an unnecessary effort.

Of course, if you know of interesting hardware that doesn't meet these,
let's figure out what the real minimum level should be.

> Somehow I feel like you haven't seen my review mails on your first 
> attempt of this series, have you?

I'll go back and look; I think I accidentally dropped a pile of mail
last week though.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140320/f844125b/attachment.sig>


More information about the xorg-devel mailing list