[PATCH 02/20] mi: miPutImage with XYPixmap failed at depth 32 on 64-bit machines

[Keith Packard]

Aaron Plattner <aplattner at nvidia.com> writes:

> Sorry for not noticing this when I fixed the other one.  Also, since 
> 2006 I learned that you can use 1UL instead of a cast to unsigned long, 
> if that seems cleaner.

Nah; the cast seems more visible, which (in this case) seems like a good
idea.

Going through the whole X server and swapping 'unsigned long' to
'uint32_t' seems like an even better plan, but that's not happening for
1.16, given how many bugs that's likely to generate :-)

> I still think we should make the server replace all XYPixmap images with 
> a picture of something rude.

Application developers still fall into the XYimage trap from time to
time; I wonder if we could figure out a way to have that generate a
compiler warning (or even an error). 

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140319/e6190623/attachment.sig>