[PATCH 3/2] Build fbcmap_mi.c once, rather than for each DDX

Gaetan Nadon memsize at videotron.ca
Wed Mar 19 14:29:54 PDT 2014


On 14-03-03 10:08 AM, Jon TURNEY wrote:
> Build fbcmap_mi.c once, rather than for each DDX, and make it part of libfb or
> libwfb convenience library.
>
> Since 84e8de1271bb11b5b4b9747ae4647f47333a8ab7 we don't have fbcmap.c
>
> This is a sort of revert of 7ecc2d526c4ea5db2589644a2fec0daf71df36da
>

kdrive fbdev fails because libkdrivestubs is added in configure.ac.
Consider this change:

    diff --git a/configure.ac b/configure.ac
    index 162c0cf..d7a55a4 100644
    --- a/configure.ac
    +++ b/configure.ac
    @@ -2400,8 +2400,7 @@ if test "$KDRIVE" = yes; then
                fi
                ;;
         esac
    -    KDRIVE_STUB_LIB='$(top_builddir)/hw/kdrive/src/libkdrivestubs.la'
    -    KDRIVE_LOCAL_LIBS="$MAIN_LIB $DIX_LIB $KDRIVE_LIB $KDRIVE_STUB_LIB"
    +    KDRIVE_LOCAL_LIBS="$MAIN_LIB $DIX_LIB $KDRIVE_LIB"
         KDRIVE_LOCAL_LIBS="$KDRIVE_LOCAL_LIBS $FB_LIB $MI_LIB
    $KDRIVE_PURE_LIBS"
         KDRIVE_LOCAL_LIBS="$KDRIVE_LOCAL_LIBS $KDRIVE_OS_LIB"
         KDRIVE_LIBS="$KDRIVE_LOCAL_LIBS $XSERVER_SYS_LIBS $GLX_SYS_LIBS
    $DLOPEN_LIB

I used these configure options:

    --enable-dmx --enable-kdrive --enable-xfake --enable-xfbdev
    --enable-xnest --enable-glamor

Note that kdrive ephyr fails to compile without glamor enabled.

        XNEST_LIBS="$FB_LIB ...


It looks like Xnest does not need libfb at all which is set in
configure.ac. It does not cause any problem, however.

Thanks for the patch!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140319/3400086b/attachment.html>


More information about the xorg-devel mailing list