[PATCH synaptics] Disable GrabEventDevice by default

Peter Hutterer peter.hutterer at who-t.net
Tue Mar 18 22:12:56 PDT 2014


This was required when we started supporting hotplugging to avoid duplicate
events. These days the drawback of not being able to record events in the case
of a bug is significant, possibly more so than whatever static
configurations are still out there. Let's see how much pain this causes.

Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
---
This is likely going to cause the usual shitstorm, but it may just work.
For those without custom configuration this has no effect (other than
being able to record the touchpad with evemu).
For those with an InputClass section, this has no effect.

Those with a static InputDevice configuration and auto-dev may get duplicate
devices now. Let's see how big the fallout is from that. We can add
duplicate detection to the synaptics driver (à la evdev) if it turns out to
be a problem.

 src/synaptics.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/synaptics.c b/src/synaptics.c
index 07fd450..ef30920 100644
--- a/src/synaptics.c
+++ b/src/synaptics.c
@@ -747,7 +747,7 @@ set_default_parameters(InputInfoPtr pInfo)
         xf86SetRealOption(opts, "PressureMotionMinFactor", 1.0);
     pars->press_motion_max_factor =
         xf86SetRealOption(opts, "PressureMotionMaxFactor", 1.0);
-    pars->grab_event_device = xf86SetBoolOption(opts, "GrabEventDevice", TRUE);
+    pars->grab_event_device = xf86SetBoolOption(opts, "GrabEventDevice", FALSE);
     pars->tap_and_drag_gesture =
         xf86SetBoolOption(opts, "TapAndDragGesture", TRUE);
     pars->resolution_horiz =
-- 
1.8.5.3



More information about the xorg-devel mailing list