[PATCH 1/2] glamor_*gl_has_extension: Move strlen after check for NULL string

Alan Coopersmith alan.coopersmith at oracle.com
Thu Mar 13 12:53:27 PDT 2014


On 03/13/14 11:40 AM, Eric Anholt wrote:
> Keith Packard <keithp at keithp.com> writes:
>
>> Alan Coopersmith <alan.coopersmith at oracle.com> writes:
>>
>>> Flagged by cppcheck 1.64:
>>> [glamor/glamor_core.c:536] -> [glamor/glamor_core.c:540]:
>>>      (warning) Possible null pointer dereference: extension - otherwise
>>>                it is redundant to check it against null.
>>> [glamor/glamor_egl.c:620] -> [glamor/glamor_egl.c:622]:
>>>      (warning) Possible null pointer dereference: extension - otherwise
>>>                it is redundant to check it against null.
>>>
>>> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>>> Reviewed-by: Eric Anholt <eric at anholt.net>
>>
>> Alan -- I can merge these directly, but I think I'd rather have them
>> come through Eric's Glamor tree at this point so that he can sequence
>> things as he prefers.
>
> OK, sounds good.  I've pulled 2/2 in, since 1/2's code is all deleted in
> the giant new series.

Works for me - thanks.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list