[PATCH 1/2] glamor_*gl_has_extension: Move strlen after check for NULL string

Keith Packard keithp at keithp.com
Tue Mar 11 22:19:22 PDT 2014


Alan Coopersmith <alan.coopersmith at oracle.com> writes:

> Flagged by cppcheck 1.64:
> [glamor/glamor_core.c:536] -> [glamor/glamor_core.c:540]:
>     (warning) Possible null pointer dereference: extension - otherwise
>               it is redundant to check it against null.
> [glamor/glamor_egl.c:620] -> [glamor/glamor_egl.c:622]:
>     (warning) Possible null pointer dereference: extension - otherwise
>               it is redundant to check it against null.
>
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> Reviewed-by: Eric Anholt <eric at anholt.net>

Alan -- I can merge these directly, but I think I'd rather have them
come through Eric's Glamor tree at this point so that he can sequence
things as he prefers.

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 810 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140311/63043889/attachment.pgp>


More information about the xorg-devel mailing list