[PATCH 1/6] xephyr: Build support for rendering with glamor using a -glamor option.

Eric Anholt eric at anholt.net
Fri Mar 7 12:55:00 PST 2014


Jon TURNEY <jon.turney at dronecode.org.uk> writes:

> On 25/02/2014 01:47, Eric Anholt wrote:
>> v2: Avoid making the Ximage for the screen that we'll never use, and
>>     drive the screen pixmap creation for glamor ourselves.
>> 
>> Signed-off-by: Eric Anholt <eric at anholt.net>
>> Reviewed-by: Keith Packard <keithp at keithp.com> (v1)
>
> It seems this needs some more #ifdef GLAMOR/#endif guards to compile
> successfully when ./configured --disable-glamor
>
> See http://tinderbox.x.org/builds/2014-03-07-0004/logs/xserver/#build

Sent out a pull request for the reviewed change.

The ifdeffing is kind of ugly, but I'm already guilty of a bunch of that
in this code.  I like the idea of static inline stubs for compiled-out
code, but it's only partially done in ephyr_glamor_glx.h so far.  We can
leave that as a cleanup for later.

It would be nice to have a cleaner version of the static inline thing
than what I've done currently.  Not sure if preprocessor macros could be
used to make doing that more sane, or less.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140307/16c7022b/attachment.pgp>


More information about the xorg-devel mailing list