[PATCH 1/2] xf86Config: Fix warning: declaration of 'Pointer' shadows a global

Eric Anholt eric at anholt.net
Tue Mar 4 17:15:51 PST 2014


Hans de Goede <hdegoede at redhat.com> writes:

> This fixes the following compiler warning:
>
> xf86Config.c: In function 'checkCoreInputDevices':
> xf86Config.c:1136:18: warning: declaration of 'Pointer' shadows a global declaration [-Wshadow]
>      InputInfoPtr Pointer, Keyboard;
>                   ^
> In file included from xf86Xinput.h:57:0,
>                  from xf86Config.c:66:
> /opt/xorg/include/X11/extensions/XIproto.h:88:24: warning: shadowed declaration is here [-Wshadow]
>  typedef unsigned char *Pointer;
>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>

Looks like keithp just hasn't pusehd the reviewed change for inputproto
yet.  I'd rather see that land.

Patch 2/2 is:

Reviewed-by: Eric Anholt <eric at anholt.net>

(I had similar, but it got nitpicked and I just don't care what type
gets used).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140304/f460973a/attachment.pgp>


More information about the xorg-devel mailing list