[PATCH 3/3] Require video drivers to report that they support server managed fds

Alan Coopersmith alan.coopersmith at oracle.com
Tue Mar 4 15:22:15 PST 2014


On 03/ 4/14 08:56 AM, Hans de Goede wrote:
> Hi,
>
> On 03/03/2014 06:01 PM, Alan Coopersmith wrote:
>> On 03/ 3/14 08:26 AM, Hans de Goede wrote:
>>> +#include "systemd-logind.h"
>>
>> Shouldn't that be in an #ifdef for systemd platforms only?
>
> systemd-logind.h has the ifdef internally and defines (always failing)
> stubs for all the systemd_logind functions for non systemd platforms,
> this way we can avoid sprinkling #ifdef's all over the place.

Okay - I'd not paid attention to the previous patches, and since Keith
hasn't pulled them to git master yet don't have a copy to see that.

Centralizing them in the header is fine, as long as the build works for
those of us on other platforms.


-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list