[PATCH 1/2] platform: support non-pci platform devices

[Rob Clark]

On Mon, Jun 23, 2014 at 10:54 AM, Thierry Reding
<thierry.reding at gmail.com> wrote:
> On Mon, Jun 16, 2014 at 02:13:16PM -0400, Rob Clark wrote:
> [...]
>> diff --git a/hw/xfree86/common/xf86platformBus.c b/hw/xfree86/common/xf86platformBus.c
> [...]
>> +static int
>> +find_non_pci_driver(const char *busid, char *returnList[], int returnListMax)
>> +{
>> +    /* Add more entries here if we ever return more than 4 drivers for
>> +       any device */
>> +    const char *driverList[5] = { NULL, NULL, NULL, NULL, NULL };
>> +    int i = 0;
>> +    char *p, *s;
>> +
>> +    s = xstrdup(busid);
>> +    p = strtok(s, ":");
>> +
>> +    if (strcmp(p, "platform"))
>> +        goto out;
>
> This isn't going to work on Tegra since we don't have a platform device
> there. drmGetBusid() returns "drm" on Tegra.

umm, could you fix that in your driver?  I'd prefer not to match on
anything that is !pci, since that seems overly broad and the sort of
thing that will eventually backfire.  Otherwise I guess you still have
an incentive to make sure the OutputClass stuff gets merged so we
eventually have a better solution ;-)

BR,
-R

> Thierry