[PATCH util/modular] Add gpg signing to release.sh

[Gaetan Nadon]

On 14-06-07 03:57 PM, Stephen Kitt wrote:
> From 283b89da292ad8a5743222baf33393d964cff54b Mon Sep 17 00:00:00 2001
> From: Stephen Kitt <skitt at debian.org>
> Date: Sun, 1 Jun 2014 14:46:01 +0200
> Subject: [PATCH util/modular] Add gpg signing to release.sh
>
> gpg-sign the git tag and the generated tarballs, and upload the signatures
> along with the tarballs. Any existing tarball signatures are removed
> beforehand.
>
> Signed-off-by: Stephen Kitt <skitt at debian.org>
>
> Modified by Alan Coopersmith to handle gpg vs. gpg2 paths for Solaris.
>
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
>  release.sh | 48 ++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 46 insertions(+), 2 deletions(-)
>
> diff --git a/release.sh b/release.sh
> index a4a725d..6389bc6 100755
> --- a/release.sh
> +++ b/release.sh
> @@ -193,6 +193,29 @@ process_modules() {
>  }
>  
>  #------------------------------------------------------------------------------
> +#                       Function: sign_or_fail
> +#------------------------------------------------------------------------------
> +#
> +# Sign the given file, if any
> +# Output the name of the signature generated to stdout (all other output to
> +# stderr)
> +# Return 0 on success, 1 on fail
> +#
> +sign_or_fail() {
> +    if [ -n "$1" ]; then
> +	sig=$1.sig
> +	rm -f $sig
> +	$GPG -b $1 1>&2
> +	if [ $? -ne 0 ]; then
> +	    echo "Error: failed to sign $1." >&2
> +	    return 1
> +	fi
> +	echo $sig
This echo statement does not appear for me. Perhaps because the function
is called from $(). I do get the gpg message:

    You need a passphrase to unlock the secret key for
    user: "Gaetan Nadon <memsize at videotron.ca>"
    1024-bit DSA key, ID FB9EC9FC, created 2008-12-16

Not a big deal,

Reviewed-by: Gaetan Nadon<memsize at videotron.ca>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140608/d5b91d0f/attachment.html>