Assertion failure in SecurityDeleteAuthorization (xorg-server 1.14.4)

[Jeremy Huddleston Sequoia]

Hey Peter,

Do you think that the double decrement that you fixed in the commit at the bottom is related to the issue reported with the 1.14 server in this ticket?  Maybe by SecurityDeleteAuthorization getting called a second time?  If not, any idea why this might be happening?

http://xquartz.macosforge.org/trac/ticket/869

Assertion failed: (status), function SecurityDeleteAuthorization, file security.c, line 181.

62	2   libsystem_c.dylib                   0x00007fff8ac7bbba abort + 125
63	3   libsystem_c.dylib                   0x00007fff8ac45a5f __assert_rtn + 321
64	4   X11.bin                             0x000000010005b590 SecurityDeleteAuthorization + 378
65	5   X11.bin                             0x00000001000e6019 doFreeResource + 105
66	6   X11.bin                             0x00000001000e5f8b FreeResource + 200
67	7   X11.bin                             0x000000010005c798 SecurityAuthorizationExpired + 52
68	8   X11.bin                             0x000000010010e036 DoTimer + 50
69	9   X11.bin                             0x000000010010de51 WaitForSomething + 1726
70	10  X11.bin                             0x00000001000c45b0 Dispatch + 142
71	11  X11.bin                             0x0000000100026467 dix_main + 961

commit 132507eba93e4dfd466d5c30c9b818cdc6f8536e
Author: Peter Harris <pharris at opentext.com>
Date:   Mon Jul 15 19:44:45 2013 -0400

    security: Don't count RetainPermanent clients twice
    
    If a RetainPermanent client is subsequently killed by a KillClient
    request, the reference count is decremented twice. This can cause the
    server to prematurely kill other clients using the same Authorization.
    
    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Signed-off-by: Peter Harris <pharris at opentext.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4109 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140722/9a4c87d9/attachment.bin>