[PATCH] Fix ODEV_ATTRIB_DRIVER overlapping with ODEV_ATTRIB_FD

Hans de Goede hdegoede at redhat.com
Sat Jul 12 06:18:49 PDT 2014


Hi,

On 07/12/2014 01:35 PM, Julien Cristau wrote:
> On Fri, Jul 11, 2014 at 10:41:11 +0200, Hans de Goede wrote:
>
>> Looks like the value of ODEV_ATTRIB_DRIVER was not updated when the patch
>> adding it got rebased on top of a newer server version.
>>
>> This fixes the xserver crashing when systemd-logind integration is used.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=1118540
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> ---
>>  include/hotplug.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
> Does any driver use ODEV_ATTRIB_DRIVER?  (Trying to figure out if this
> needs an ABI bump...)

ODEV_ATTRIB_DRIVER was introduced in 1.15.99.904, and no new
driver versions have been released since then AFAIK, iow
I think that we should fix this ASAP and the fix then does
not need an ABI bump.

Keith, I've a plan to make the API more robust, not sure if I'll
get around to it before monday. Given the above it would be nice if
you could push the fix ASAP though.

Regards,

Hans


More information about the xorg-devel mailing list