[PATCH] Fix locking bugs with XIAllowTouchEvents() and XIUngrabTouchBegin()

Owen Taylor otaylor at redhat.com
Fri Jul 11 12:15:22 PDT 2014


Jasper St. Pierre wrote:
> int touchid,
> LockDisplay(dpy);
> if (_XiCheckExtInit(dpy, XInput_2_2, extinfo) == -1)
> return (NoSuchExtension);
> -
> - status = _XIAllowEvents(dpy, deviceid, event_mode, CurrentTime, touchid,
> grab_window);
> -
> UnlockDisplay(dpy);
> - SyncHandle();
> 
> - return status;
> + return _XIAllowEvents(dpy, deviceid, event_mode, CurrentTime, touchid,
> grab_window);
> 
> Shouldn't you remove the declaration for "status" here?

Yes, thanks - new version sent.

- Owen


More information about the xorg-devel mailing list