[PATCH v2 RESEND 0/5] Support autoloading of non-PCI drivers

Aaron Plattner aplattner at nvidia.com
Tue Jul 8 09:53:45 PDT 2014


On 07/08/2014 05:44 AM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Mon, Jul 07, 2014 at 04:08:58PM -0700, Keith Packard wrote:
>> David Airlie <airlied at redhat.com> writes:
>>
>>> I'm assuming they don't break API/ABI,
>>
>> Yeah, I've reviewed them for API/ABI changes and they're clean for
>> external drivers at least.
>
> Aaron did test them on our proprietary stack as far as I know, and I
> guess I had always assumed that he had tested them for ABI breakage too,
> though admittedly I don't know.
>
> Aaron did you specifically check if these patches don't break anything
> if you don't rebuild the driver?

Yes.  I actually just tested this again yesterday with 1.15.99.904 and 
it works great.

> I'm certainly not aware that the series changes any symbols that are
> exported to drivers, so I don't think it could possibly break.

I think it's fine from an ABI and API standpoint.  Thanks for looking 
out for ABI breaks!  :)

>>> I don't think 1.16.1 is suitable, I think extend 1.16 by two weeks, and shove
>>> another pre-release out the door, so we can stick it in rawhide for a least a week.
>>
>> I'll merge them in and push out a release. Let's plan on doing 1.16 next
>> Wednesday unless we get any hints of problems. I really don't want to
>> drag this release out a lot further.
>
> Sounds good to me. Thanks a lot for doing this.
>
> Thierry



More information about the xorg-devel mailing list