[PATCH 2/7] xkb: add a call to init an XkbRMLVOSet from const chars

Peter Hutterer peter.hutterer at who-t.net
Thu Jan 30 02:10:07 PST 2014


On Thu, Jan 30, 2014 at 10:18:33AM +0100, Mark Kettenis wrote:
> > Date: Thu, 30 Jan 2014 09:40:33 +0100
> > From: Hans de Goede <hdegoede at redhat.com>
> > 
> > This should use the new XkbInitRules rather then diy strdup, so as
> > to be balanced wrt to the XkbFreeRMLVOSet call.
> 
> That may be true, but it is better to do a straight revert first and
> then make improvements on top of that.

straight reverts aren't always possible because many of the patches mashed
a whole bunch of unrelated things together. Short of reverting most
if not all patches, I think this will have to be an incremental process.

Cheers,
   Peter


More information about the xorg-devel mailing list