[PATCH] Replace 'pointer' with the equivalent 'void *'.

Gaetan Nadon memsize at videotron.ca
Mon Jan 20 08:27:04 PST 2014


On 14-01-19 07:52 PM, Keith Packard wrote:
> Gaetan Nadon <memsize at videotron.ca> writes:
>
>> > On 14-01-19 04:01 PM, Keith Packard wrote:
>>> >> The pointer typedef is being removed because it causes so many
>>> >> compiler warnings when -Wshadow is enabled.
>>> >>
>>> >> Signed-off-by: Keith Packard <keithp at keithp.com>
>>> >> ---
>>> >>  fontproto.h  |  2 +-
>>> >>  fontstruct.h | 36 ++++++++++++++++++------------------
>>> >>  2 files changed, 19 insertions(+), 19 deletions(-)
>> >
>> > Code changes are ok, but patch does not apply. Looks like lines are offset.
>> >
>> >     Applied patch fontproto.h cleanly.
>> >     Applying patch fontstruct.h with 2 rejects...
>> >     Hunk #1 applied cleanly.
>> >     Rejected hunk #2.
>> >     Rejected hunk #3.
>> >
>> > I am on master branch top commit  d84789dc33
> Right, this patch is on top of a previous fontsproto patch which also
> has not been applied. That one allowed paths and patterns to be declared
> const. I'll attach that here; the pointer patch comes after this one.

Now applies correctly,

Reviewed-by: Gaetan Nadon <memsize at videotron.ca>








More information about the xorg-devel mailing list