[PATCH 00/37] Warning fixes (post 1.15 proposed changes)

Colin Harrison colin.harrison at virgin.net
Mon Jan 13 16:07:51 PST 2014


Hi,

This message was sent before the last one?
(maybe Biff the dog ran off and buried it!)
Apologies if it now appears twice!

Some const GC funcs and ops were missed in rootless...

--- ./miext/rootless/save_rootlessGC.c  2014-01-13 08:09:28.124320860 +0000
+++ ./miext/rootless/rootlessGC.c       2014-01-13 18:31:27.668467154 +0000
@@ -403,7 +403,7 @@
 #define GCOP_UNWRAP(pGC) \
     RootlessGCRec *gcrec = (RootlessGCRec *) \
         dixLookupPrivate(&(pGC)->devPrivates, rootlessGCPrivateKey); \
-    GCFuncs *saveFuncs = pGC->funcs; \
+    const GCFuncs *saveFuncs = pGC->funcs; \
     (pGC)->funcs = gcrec->originalFuncs; \
     (pGC)->ops = gcrec->originalOps;

And

--- ./miext/rootless/save_rootlessCommon.h      2013-05-24
07:01:08.000000000 +0100
+++ ./miext/rootless/rootlessCommon.h   2014-01-13 15:37:06.933788427 +0000
@@ -70,8 +70,8 @@

 // RootlessGCRec: private per-gc data
 typedef struct {
-    GCFuncs *originalFuncs;
-    GCOps *originalOps;
+    const GCFuncs *originalFuncs;
+    const GCOps *originalOps;
 } RootlessGCRec;

 // RootlessScreenRec: per-screen private data

Thanks,
Colin Harrison







More information about the xorg-devel mailing list