[PATCH randrproto] spec: RRCrtcChangeMask and RROutputChangeMask are not things

Alan Coopersmith alan.coopersmith at oracle.com
Mon Jan 6 21:58:22 PST 2014


On 01/ 6/14 09:39 PM, Aaron Plattner wrote:
> The correct names for these are RRCrtcChangeNotifyMask and
> RROutputChangeNotifyMask, respectively.
>
> Signed-off-by: Aaron Plattner <aplattner at nvidia.com>
> ---
>   randrproto.txt | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/randrproto.txt b/randrproto.txt
> index 2123e7e..afd6921 100644
> --- a/randrproto.txt
> +++ b/randrproto.txt
> @@ -406,19 +406,19 @@ The name of this extension is "RANDR".
>
>   	New for version 1.2:
>
> -	If 'enable' contains RRCrtcChangeMask, RRCrtcChangeNotify events
> +	If 'enable' contains RRCrtcChangeNotifyMask, RRCrtcChangeNotify events
>   	will be sent when a the configuration for a CRTC associated with the
>   	screen changes, either through this protocol extension or due to
>   	detected external changes. RRCrtcChangeNotify may also be sent when
>   	this request executes if the CRTC configuration has changed since
>   	the client connected, to avoid race conditions.
>
> -	If 'enable' contains RROutputChangeMask, RROutputChangeNotify events
> -	will be sent when a the configuration for an output associated with
> -	the screen changes, either through this protocol extension or due to
> -	detected external changes. RROutputChangeNotify may also be sent
> -	when this request executes if the output configuration has changed
> -	since the client connected, to avoid race conditions.
> +	If 'enable' contains RROutputChangeNotifyMask, RROutputChangeNotify
> +	events will be sent when a the configuration for an output associated
> +	with the screen changes, either through this protocol extension or due
> +	to detected external changes. RROutputChangeNotify may also be sent when
> +	this request executes if the output configuration has changed since the
> +	client connected, to avoid race conditions.
>
>   	If 'enable' contains RROutputPropertyNotifyMask,
>   	RROutputPropertyNotify events will be sent when properties change on
>

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

Though if you also wanted to remove the extra "a" from both paragraphs, where
it says "will be sent when a the configuration", that'd be nice too.

-- 
	-Alan Coopersmith-              alan.coopersmith at oracle.com
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc


More information about the xorg-devel mailing list