[PATCH xf86-input-synaptics 5/8] Don't report motion inside soft-button areas

[Carl Worth]

[Hans, I apologize for the re-send. My first version of this mail
apparently didn't go to the list. There are some updates in the below
compared to what I sent before.]

Hans de Goede <hdegoede at redhat.com> writes:
> Unless the motion has started outside the soft-button area.
...
> This fixes the reporting of unintended motion just before a click in a
> soft button area which sometimes causes mis-clicks.

Hurrah! Thank you for this patch.

I haven't experimented with the TopSoftButtonArea, (since it is harder
to get at, not being exposed in a parameter), but with this patch I did
successfully configure my touchpad so that the top area generates
clicks, (left, middle, or right), with no motion.

Here's the configuration I am now using:

  xinput set-prop 'SynPS/2 Synaptics TouchPad' 'Synaptics Soft Button Areas' 3951 0 0 1700 2950 3950 0 1700

Thanks to Keith Packard for suggesting using names rather than numeric
IDs, and for trimming down the regions to just the top area where
expected.

The left and right boundaries I determined empirically so that I don't
get a middle-click unless I'm actually touching at least two of the
small bumps near the middle of the top edge of my touchpad. And if I'm
touching no bumps, I get either a left or a right mouse click as
desired.

The bottom boundary is designed to size the button area so that the red
line drawn near the top of the clickpad is centered (top-to-bottom) in
the area. This seems like what a user would expect.

[I mentioned in my earlier email to Hans that I wasn't getting
two-finger scrolling with this, but it actually seems to be working
fine now.]

The above values are working well enough for me now that they could even
be a reasonable default for laptops with this style of button-less
trackpoint. I can finally use my new Lenovo laptop's trackpoint without
needing an external mouse.

So this gets my:

Tested-by: Carl Worth <cworth at cworth.org>

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140227/abecfd21/attachment.pgp>