[PATCH] Add devd config backend for FreeBSD (and GNU/kFreeBSD)

[Guillem Jover]

On Mon, 2014-02-24 at 22:27:54 +0000, Robert Millan wrote:
> On 22/02/2014 16:12, Guillem Jover wrote:
> >> +++ b/config/devd.c
> >> @@ -0,0 +1,365 @@
> >> +/*
> >> + * Copyright ?? 2012 Baptiste Daroussin
> > 
> > Encoding issue? Should be ©, I guess.
> 
> It's © in the actual file - just checked.

It seems the attachment does not contain a charset attribute in its
Content-Type: field header. ISTR «git send-email» adds one for me.

> > realloc() can do the initial alloc if buf is NULL.
> 
> What would be the point in that?

It makes sure the code path leading to the realloc() is always exercised
and tested, because otherwise going over 1 KiB might not happen too
often. And reduces logic duplication.

> This change pessimizes on the common case by adding
> two extra in-loop branches, without actually saving any cost since
> the allocation needs to happen anyway.

You mean on a loop that is performing a syscall per byte, ok.

Anyway, I'm not the one who's going to merge such changes, so…

Thanks,
Guillem