[PATCH] arch: Fix image and bitmap byte order for ppc64le
Egbert Eich
e4t at freenet.de
Mon Feb 24 02:37:41 PST 2014
On Mon, Feb 24, 2014 at 11:18:27AM +0100, Mark Kettenis wrote:
> > X-Original-To: xorg-devel at lists.x.org
> > From: Egbert Eich <eich at freedesktop.org>
> > Date: Mon, 24 Feb 2014 10:57:23 +0100
> >
> > From: Dinar Valeev <dvaleev at suse.com>
> >
> > So far PPC was big endian for sure. For ppc64le this is no longer
> > true.
>
> Isn't it safer to revert the logic? I'm not sure all
> compilers/platforms define __BIG_ENDIAN__ when appropriate, and in
> that case existing working PowerPC platforms will get the wrong byte
> orders. So something like:
I've used the __BIG_ENDIAN__ define before to differentiate between
the two most common endianesses and it has always worked - also on
PPC (BE). But to make sure there is no breakage I will send a new
patch.
Cheers,
Egbert.
More information about the xorg-devel
mailing list