[PATCH v2] arch: Fix image and bitmap byte order for ppc64le

Guillem Jover guillem at hadrons.org
Mon Feb 24 08:19:32 PST 2014


On Mon, 2014-02-24 at 08:09:33 -0800, Keith Packard wrote:
> walter harms <wharms at bfs.de> writes:
> > Assuming that __LITTLE_ENDIAN__ is of general interest,
> > i would avoid defined(__ppc__) and friends otherwise we will need to define
> > this for every achitecture.
> 
> That would risk breaking little endian platforms that failed to define
> this. Safest to limit the scope of the change the PPC platforms, where
> __LITTLE_ENDIAN__ is a new option, and hence likely to be set correctly.
> 
> I would sure like to be able to detect the difference between 'this
> option is set to false' and 'this option isn't defined'; is there
> something that PPC defines in both cases, and sets to TRUE in one case
> and FALSE in the other?

I'm probably missing something (maybe this header cannot include a
dix-config.h or equivalent), but why not use AC_C_BIGENDIAN?

Thanks,
Guillem


More information about the xorg-devel mailing list