[PATCH xf86-input-synaptics 7/8] On button down update cumulative to current x and y, instead of previous
Hans de Goede
hdegoede at redhat.com
Fri Feb 21 01:31:43 PST 2014
When a button click and new coordinates get reported in one go we sync the
cumulative coordinates to the old x and y, rather then the newly reported ones.
This keeping of the old coordinates causes the following issue:
-touch the touchpad in its right click area
-let go of the touchpad
-rapidly click in the left click area (or middle area), so that the
new location and the click get reported in one syn (may require some
practicing with evemu-record to reproduce)
-the driver registers the click as a right click because it uses the
old coordinates from the cumulative coordinates to determine the
click location
Signed-off-by: Hans de Goede <hdegoede at redhat.com>
---
src/eventcomm.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/eventcomm.c b/src/eventcomm.c
index 7fc408f..fe57aa8 100644
--- a/src/eventcomm.c
+++ b/src/eventcomm.c
@@ -671,6 +671,7 @@ EventReadHwState(InputInfoPtr pInfo,
SynapticsPrivate *priv = (SynapticsPrivate *) pInfo->private;
SynapticsParameters *para = &priv->synpara;
struct eventcomm_proto_data *proto_data = priv->proto_data;
+ Bool sync_cumulative = FALSE;
SynapticsResetTouchHwState(hw, FALSE);
@@ -678,6 +679,7 @@ EventReadHwState(InputInfoPtr pInfo,
if (!hw->left && !hw->right && !hw->middle) {
hw->cumulative_dx = hw->x;
hw->cumulative_dy = hw->y;
+ sync_cumulative = TRUE;
}
while (SynapticsReadEvent(pInfo, &ev)) {
@@ -753,9 +755,13 @@ EventReadHwState(InputInfoPtr pInfo,
switch (ev.code) {
case ABS_X:
hw->x = apply_st_scaling(proto_data, ev.value, 0);
+ if (sync_cumulative)
+ hw->cumulative_dx = hw->x;
break;
case ABS_Y:
hw->y = apply_st_scaling(proto_data, ev.value, 1);
+ if (sync_cumulative)
+ hw->cumulative_dy = hw->y;
break;
case ABS_PRESSURE:
hw->z = ev.value;
--
1.9.0
More information about the xorg-devel
mailing list