[PATCH xserver 1/5] hw: use links in git to share source files due to upcoming automake changes

Gaetan Nadon memsize at videotron.ca
Tue Feb 18 08:24:23 PST 2014


On 14-02-18 07:35 AM, Jon TURNEY wrote:
> I'd say if we are building the same object in different places, this is a sign
> that something else is wrong.
>
> I wrote a patch some time ago to build dpmsstubs.c as a convenience library
> [1], and this would seem to be the better approach to this problem wherever
> possible.
>
> miinitext.c is somewhat a special case as it needs to be built differently for
> each DDX, but did you consider moving it's contents to a .h file and then
> #include'ing it in each DDX?
Most likely what you propose would be a better technical solution. Not
having xserver code knowledge, I am not in a position to pursue such an
endeavour, particularly given the large number of Makefiles involved.
Not to mention the risk of breaking existing hacks I am not aware of.

That's why I thought of this more brain dead mechanical approach which
has the merit of being expeditive and does not prevent developers with
the "know how" to replace all or a portion of the links with proper code
re-factoring.

The patch you mention is dating from 2011, most likely does not apply.
You may rework the patch based on patch #1 in this series and I can
squash yours and repost the series. Or just append it at the end.

Contributions are welcome!


More information about the xorg-devel mailing list