Would anybody mind the "Drop circular pad support" patch being reverted?

[Peter Hutterer]

On Thu, Feb 13, 2014 at 05:09:05PM -0800, Bart Massey wrote:
> Daniel, thanks much for the explanation! I sympathize, I really do.
> But it seems to me that retaining working code that folks are actually
> using has to be a higher priority than simplification.  --Bart

I hadn't seen a single configuration file that set that option in years, so
tbh I had no idea whether this code was being used let alone whether it was
working. Generally, given the state of the rest of the driver, I assume that
anything that's not used is probably broken.

And finding modern laptops with circular touchpads isn't that easy either.
Also, please note that the support was removed two years ago, with a driver
release almost a year ago now. So it did take quite a while for anyone to
even notice/complain.

Aaaanyway, revert is on the list, as soon as I get a tested-by I can push
it.

Cheers,
   Peter

> 
> On Thu, Feb 13, 2014 at 6:19 AM, Daniel Stone <daniel at fooishbar.org> wrote:
> > Hi,
> >
> > On 12 February 2014 16:26, Bart Massey <bart at cs.pdx.edu> wrote:
> >> Please revert. Keithp has a laptop like this that I've used for a
> >> while: works great. I don't understand why this patch was committed?
> >
> > It was removed to make the totally-nightmarish Synaptics driver
> > slightly easier to reason about. Following the flow and fixing bugs
> > inside that driver is near-on impossible, and anything that makes that
> > easier is great by me.
> >
> > Cheers,
> > Daniel
> > _______________________________________________
> > xorg-devel at lists.x.org: X.Org development
> > Archives: http://lists.x.org/archives/xorg-devel
> > Info: http://lists.x.org/mailman/listinfo/xorg-devel
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>