[RFC 1/3] xfree86: Store kernel driver name in platform device attribute

[Thierry Reding]

On Thu, Feb 13, 2014 at 08:41:15AM -0800, Aaron Plattner wrote:
> On 02/13/14 05:22, Thierry Reding wrote:
[...]
> >diff --git a/hw/xfree86/os-support/linux/lnx_platform.c b/hw/xfree86/os-support/linux/lnx_platform.c
[...]
> >@@ -52,6 +53,17 @@ get_drm_info(struct OdevAttributes *attribs, char *path, int delayed_index)
> >      xf86_add_platform_device_attrib(delayed_index,
> >                                      ODEV_ATTRIB_BUSID, buf);
> >      drmFreeBusid(buf);
> >+
> >+    v = drmGetVersion(fd);
> >+    if (!v) {
> >+        ErrorF("getversion failed\n");
> 
> I know there's precedent in this function, but this error message could use
> some more info.  Maybe something like this?
> 
>   xf86Msg(X_ERROR, "%s: failed to query DRM version\n", path);

Yes, that reads a lot better.

> Other than that,
> 
> Reviewed-by: Aaron Plattner <aplattner at nvidia.com>

Thanks!
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140213/cbd163c0/attachment.pgp>