[RFC 0/2] Allow non-PCI devices to act as primary

Thierry Reding thierry.reding at gmail.com
Thu Feb 13 05:50:02 PST 2014


The current implementation of the xf86platformBus assumes that only PCI
devices can be primary devices. One of the issues that this causes for
non-PCI devices is that the driver's ->platformProbe() function won't be
called to create the primary screen and therefore cause the fallback to
the old probe method:

	[3916058.476] (WW) Falling back to old probe method for opentegra

The reason for that is that xf86platformProbeDev() skips non-primary and
non-PCI devices when trying to create a screen. However devices that do
not have a PCI GPU can still have a primary device.

This series attempts to fix this by falling back to using the first
device as primary if no other bus and device have been set up as
primary. This should ensure that PCI setups will continue to work as
before.

The second patch in the series makes sure that the check for the primary
device in xf86platformProbeDev() includes non-PCI devices to make the
non-fallback path work for SoCs as well.

Thierry

Thierry Reding (2):
  xfree86: Fallback to first platform device as primary
  xfree86: Allow non-PCI devices as primary

 hw/xfree86/common/xf86Bus.c         |  3 +++
 hw/xfree86/common/xf86platformBus.c | 24 ++++++++++++++++++++----
 hw/xfree86/common/xf86platformBus.h |  1 +
 3 files changed, 24 insertions(+), 4 deletions(-)

-- 
1.8.4.2



More information about the xorg-devel mailing list