[PATCH] Enable subdir-objects

Thierry Reding thierry.reding at gmail.com
Wed Feb 12 11:35:21 PST 2014


On Wed, Feb 12, 2014 at 07:34:37PM +0100, Julien Cristau wrote:
> On Wed, Feb 12, 2014 at 17:15:26 +0100, Thierry Reding wrote:
> 
> > automake complains about the subdir-objects being missing. Enabling it,
> > however, causes various build issues to pop up because $(srcdir),
> > $(top_srcdir), $(builddir) and $(top_builddir) aren't handled properly.
> > It's simple to work around it by substituting them for their actual
> > values, though.
> > 
> Have you tested this with a vpath build?

As a matter of fact I've only tested out-of-tree builds since current
master is broken by the pointer -> void * conversions going on in the
various proto packages. I could try to upgrade my local packages to
something newer but was reluctant to fool around with my development
machine.

The out-of-tree builds I do when I cross-compile to ARM and I have
patches for the various pointer -> void * conversions applied.

When I apply this same patch on top of the 1.15.0 tag it does indeed
build successfully also in-tree. However I just noticed that I missed
to update some of the directories and didn't notice because I was
building the default configuration. Is there an easy way to get maximum
compile coverage for the X server?

> (Also, what does this subdir-objects thing do, and why do we want it?)

It essentially puts object files into a subdirectory in the build tree
named after the subdirectory where the source files come from. The most
obvious reason to use it is to avoid name conflicts.

But I don't think we have any, so there's not an immediate need. It
does, however, make autoreconf a *lot* less verbose. And it might be
useful to avoid potential name conflicts in the future.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20140212/1930636b/attachment.pgp>


More information about the xorg-devel mailing list